← Eng Cafe
Ep12. Code Review
_xg · Maggie__

Eng Cafe

Ep12. Code Review

时长
56分钟
播放
354次
发布
4年前
在小宇宙收听 ↗

Show notes

节目简介

来源:小宇宙
Pre-show
* Maggie 最近看的书:Software Engineering at Google
* Xg 加入的新公司:Airtable (👀)
本期播客涉及名词,链接:
* Code Review, Reviewer, Code Author
* Change List, Pull Request, Diff, Stacked Diffs
* LGTM: Looks Good To Me; PTAL: Please Take Another Look
* Code Review Tools: http://github.com, https://www.gerritcodereview.com, https://www.reviewboard.org, https://www.phacility.com/phabricator/, https://graphite.dev
* Google Style Guides
* Critique: Google’s Code Review Tool
* Conventional Commits
Timeline:
* 3:00 What is a code review?

* The steps
* Benefits: technical, sociological and knowledge sharing
* Why it’s sometimes hard
* 18:00 Tools and processes
* 28:50 Tips and Best practices - as reviewer
* 49:50 Tips and Best practices - as author

Listeners say

小宇宙热评

共 4 条 · 按点赞排序
  1. 杨老师没关系 TOP 1

    1

    很有帮助!谢谢分享🙏☺️

  2. 杨老师没关系 TOP 2

    0

    Code review best principles: Reviewers: • Keep a Style guide: existed style guide (gg: possibly not updated with the new language features) • Give code pointers / examples (suggested) • Can we xxx not you should xxx • This is great / learnt the trick! • 尽早开始code review: keep the momentum / or remove myself / batch review (morning / before eod) • 先达到60分 • 陷入僵局:design? Code itself? (Offline expressive/remove myself/escalate/doc/meeting) Authors: • Small change / peer review of the big changes / offline walkthrough • Draft PR, self-review, comments, manually run -> ready to review • Refactoring, feature, clean up, 3个PR or 2个 • Specify change files size • Keep the reviewers “Minimum” • Other team’s code: get Lgtm from our team first, then it’s easier to get approval from code owner team

  3. liveM数字朋克 TOP 3

    · 广东

    0

    说到 Code Review 令我想起了另一个播客,里面也有讲到😀 https://www.xiaoyuzhoufm.com/episode/65f2afde6764957079491b70

  4. 陈十二

    · 北京

    0

    赞同每个pr尽可能小,但主播是否遇到过一个大需求拆成多个pr呢,每个pr一个分支的话感觉git操作成本有点高

播放列表

自动播放下一个

播放列表还是空的

去找些喜欢的单集添加进来吧